Fixes to JSON-RPC and WebSocket clients #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vyzo
approved these changes
Mar 25, 2024
fare
approved these changes
Mar 28, 2024
|
The tests fail: |
Some servers do not accept "application/json-rpc" as Content-Type. Programmers can specialize for their own uses.
Per the spec (https://datatracker.ietf.org/doc/html/rfc6455#section-4.4) the server only sends back a Sec-Websocket-Version header if it supports versions other than the one requested by the client. Thus it was an error to fail on a missing header. We now fail on a present header since our current implementation only supports v13.
|
I rebased the branch, added the docs I asked for, and fixed the server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some JSON-RPC servers do not accept
Content-Type: application/json-rpc. The programmer must now specialize their code for their own uses.The WebSocket client was wrongly terminating when the server did not respond with a Sec-Websocket-Version header. Our logic was flawed and we now fail when it is present. See https://datatracker.ietf.org/doc/html/rfc6455#section-4.4.