Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FortiManager address and service handling #217 #222

Merged
merged 11 commits into from
Sep 26, 2024
Merged

FortiManager address and service handling #217 #222

merged 11 commits into from
Sep 26, 2024

Conversation

patrikspiess
Copy link
Member

closes #217

patrikspiess and others added 9 commits September 17, 2024 17:25
@patrikspiess
👔 Add FortiManager Methods to handle addresses and services
b198018
@patrikspiess
📝 Rename 'utils' to 'tools' and squeeze schema
c749652
@dependabot @patrikspiess
Bump urllib3 from 2.2.1 to 2.2.2
82ea268 
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.2.1...2.2.2)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @patrikspiess
Bump certifi from 2024.2.2 to 2024.7.4
dfb93ec 
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.7.4.
- [Commits](certifi/python-certifi@2024.02.02...2024.07.04)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @patrikspiess
Bump zipp from 3.18.2 to 3.19.1
f551ae7 
Bumps [zipp](https://github.com/jaraco/zipp) from 3.18.2 to 3.19.1.
- [Release notes](https://github.com/jaraco/zipp/releases)
- [Changelog](https://github.com/jaraco/zipp/blob/main/NEWS.rst)
- [Commits](jaraco/zipp@v3.18.2...v3.19.1)

---
updated-dependencies:
- dependency-name: zipp
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@patrikspiess
♻️ Refactor new methods to get consistent return values
27f8266
@patrikspiess
♻️ Optimize and finalize address and service handling
b1b14c0
@patrikspiess
👔 Add dry-run for delete methods
e330c2e
@patrikspiess
✅ Fix tests for dry-run
85b7fbf
lucmurer
lucmurer requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@lucmurer lucmurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor beautifications in the code remain, rest is good :-)

fotoobo/fortinet/fortimanager.py Show resolved Hide resolved
fotoobo/fortinet/fortimanager.py Outdated Show resolved Hide resolved
fotoobo/fortinet/fortimanager.py Outdated Show resolved Hide resolved
fotoobo/fortinet/fortimanager.py Outdated Show resolved Hide resolved
fotoobo/fortinet/fortimanager.py Outdated Show resolved Hide resolved
@lucmurer lucmurer merged commit 2c3b81c into migros:main Sep 26, 2024
5 checks passed
@patrikspiess patrikspiess mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucmurer lucmurer lucmurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FortiManager methods for address and service object handling
2 participants
@patrikspiess @lucmurer