Support FilledRectObject with blender

mikee47 · Jun 5, 2023 · 748c596 · 748c596
1 parent a5a0c5e
commit 748c596
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/src/Arch/Host/Virtual.cpp b/src/Arch/Host/Virtual.cpp
@@ -478,7 +478,7 @@ class VirtualSurface : public Surface
 			case Object::Kind::FilledRect: {
 				// Handle small transparent fills using display list
 				auto obj = reinterpret_cast<const FilledRectObject&>(object);
-				if(obj.radius != 0 || !obj.brush.isTransparent()) {
+				if(obj.blender || obj.radius != 0 || !obj.brush.isTransparent()) {
 					break;
 				}
 				Rect absRect = obj.rect + location.topLeft();

diff --git a/src/Control/Screen.cpp b/src/Control/Screen.cpp
@@ -11,10 +11,13 @@ void Screen::update(bool fullRedraw)
 		flags += Flag::redrawFull;
 	}
 
-	if(renderQueue.isActive()) {
-		return;
+	if(!renderQueue.isActive()) {
+		doUpdate();
 	}
+}
 
+void Screen::doUpdate()
+{
 	auto scene = new SceneObject(target);
 	if(flags[Flag::redrawFull]) {
 		scene->clear();
@@ -30,7 +33,7 @@ void Screen::update(bool fullRedraw)
 	renderQueue.render(scene, [this](SceneObject* scene) {
 		delete scene;
 		if(flags[Flag::redraw]) {
-			update(flags[Flag::redrawFull]);
+			doUpdate();
 		}
 	});
 }

diff --git a/src/include/Graphics/Control/Screen.h b/src/include/Graphics/Control/Screen.h
@@ -61,6 +61,8 @@ class Screen
 	virtual void handleControlEvent(ControlEvent event, Control& ctrl);
 
 private:
+	void doUpdate();
+
 	enum class Flag {
 		redraw,
 		redrawFull,

diff --git a/src/include/Graphics/Object.h b/src/include/Graphics/Object.h
@@ -245,6 +245,7 @@ class FilledRectObject : public ObjectTemplate<Object::Kind::FilledRect>
 
 	Renderer* createRenderer(const Location& location) const override;
 
+	const Blend* blender{nullptr};
 	Brush brush;
 	Rect rect;
 	uint8_t radius{0};

diff --git a/src/include/Graphics/Renderer.h b/src/include/Graphics/Renderer.h
@@ -352,13 +352,13 @@ class RectRenderer : public Renderer
 class FilledRectRenderer : public Renderer
 {
 public:
-	FilledRectRenderer(const Location& location, const Brush& brush, const Rect& rect, std::unique_ptr<Blend> blender)
-		: Renderer(location), brush(brush), rect{rect}, blender(std::move(blender))
+	FilledRectRenderer(const Location& location, const Brush& brush, const Rect& rect, const Blend* blender = nullptr)
+		: Renderer(location), brush(brush), rect{rect}, blender(blender)
 	{
 	}
 
 	FilledRectRenderer(const Location& location, const FilledRectObject& object)
-		: Renderer(location), brush(object.brush), rect(object.rect + location.dest.topLeft())
+		: Renderer(location), brush(object.brush), rect(object.rect + location.dest.topLeft()), blender(object.blender)
 	{
 	}
 
@@ -392,7 +392,7 @@ class FilledRectRenderer : public Renderer
 	Rect rect;
 	Point pos{};
 	Size blockSize;
-	std::unique_ptr<Blend> blender;
+	const Blend* blender{nullptr};
 	Buffer buffers[2];
 	uint8_t index{0};
 	uint8_t busyCount{0};