Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused usages of clojure.reflect in order to remove this dependency #351

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

irfn
Copy link
Contributor

@irfn irfn commented May 20, 2021

As discussed in Issue #349, I am removing various reflection methods which don't appear to be used anywhere.
PR is a simple removal of unused code scoped to the ones that are linked to usage of clojure.reflect

@irfn
Copy link
Contributor Author

irfn commented May 20, 2021

I didn't notice that CI was using maven. Will run maven for tests locally.

@irfn
Copy link
Contributor Author

irfn commented May 21, 2021

strange but the build passes locally using docker.
steps followed
docker build -f ./docker/Dockerfile . -t core.matrix-dev
docker run -it --entrypoint bash core.matrix-dev
this launches the shell
then run
mvn clean
mvn install -DskipTests=true -Dmaven.javadoc.skip=true
mvn test -B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant