Fix buffer overflow in foo2hbpl1 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anything for me. There's also a ton of binaries and auto-generated files that should be added to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foo2hbpl1 stopped working for me and was segfaulting on anything I tried to print. Some debugging narrowed it down to a buffer overflow of the
imagearray defined on line 606 of foo2hbpl1.c.I don't really understand what's going on in that file, but (almost) doubling the buffer size seems to have fixed the problem.
The git repo includes a bunch of binary files so they were updated too, but they should probably be added to the .gitignore (I've started one that ignores all .o files).