Skip to content

Commit

Permalink
Merge pull request thomasdavis#4 from plausibility/patch-1
Browse files Browse the repository at this point in the history
Fixed broken "warning signs" list.
  • Loading branch information
thomasdavis committed Mar 31, 2013
2 parents ef9f620 + 85041ac commit 343d035
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,17 @@ Source: http://junit.sourceforge.net/doc/testinfected/testing.htm
### Flaw #3: Brittle Global State & Singletons
#### Warning Signs
* Adding or using singletons
* Adding or using static fields or static methods Adding or using static initialization blocks Adding or using registries
* Adding or using static fields or static methods
* Adding or using static initialization blocks
* Adding or using registries
* Adding or using service locators

###Flaw #4: Class Does Too Much
####Warning Signs

* Summing up what the class does includes the word “and”
* Class would be challenging for new team members to read and quickly “get it” Class has fields that are only used in some methods
* Class would be challenging for new team members to read and quickly “get it”
* Class has fields that are only used in some methods
* Class has static methods that only operate on parameters

Source: http://misko.hevery.com/code-reviewers-guide/
Expand Down Expand Up @@ -237,4 +240,4 @@ Source: Uncle Bob Martin "Screaming Architecture" http://blog.8thlight.com/uncle
* Rule of Diversity: Distrust all claims for “one true way”.
* Rule of Extensibility: Design for the future, because it will be here sooner than you think.

Source: Eric S. Raymond "The Art of Unix Programming" http://www.catb.org/esr/writings/taoup/html/ch01s06.html
Source: Eric S. Raymond "The Art of Unix Programming" http://www.catb.org/esr/writings/taoup/html/ch01s06.html

0 comments on commit 343d035

Please sign in to comment.