refactor: read rawdata from json files instead of js import #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mileswest07
temporarily deployed
to
github-pages
… AM2R Extreme Labs and AoL Dash Spell hint icon
mileswest07
temporarily deployed
to
github-pages
|
Results:
Analysis: perhaps it would be helpful to reduce the load of the system by only calling for the rawdata.json struct once per necessary game. Should the json file be split into components for each individual game? Let's try it. |
refactor: read rawdata from component json files instead of single json fetch
mileswest07
temporarily deployed
to
github-pages
|
Results:
GTM |
mileswest07
changed the title
mileswest07
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored rawData input to read from a JSON file instead of a .JS file import. This is an important stepping stone in reducing load on the system based on targeted game modules to import.
Requires testing via a push to the Github Page, to prove end-to-end.