Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added proper return messages for drop tasks #37251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nish112022
Copy link
Contributor

issue: #37249

This is for drop collection,drop partition and drop index tasks

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nish112022
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 29, 2024
Copy link
Contributor

mergify bot commented Oct 29, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@nish112022
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 29, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 29, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.12%. Comparing base (86b9c3e) to head (086c27c).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37251       +/-   ##
===========================================
- Coverage   83.15%   67.12%   -16.03%     
===========================================
  Files        1029      290      -739     
  Lines      157251    25435   -131816     
===========================================
- Hits       130764    17074   -113690     
+ Misses      21322     8361    -12961     
+ Partials     5165        0     -5165     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.12% <ø> (∅)
Go ∅ <ø> (∅)

see 1319 files with indirect coverage changes

@nish112022
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 29, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 30, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 30, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants