Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix hasCollection response has no status #37254

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Oct 29, 2024

issue: #37257

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 29, 2024
Copy link
Contributor

mergify bot commented Oct 29, 2024

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Oct 29, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (86b9c3e) to head (56b4b77).
Report is 31 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37254      +/-   ##
==========================================
- Coverage   83.15%   80.88%   -2.27%     
==========================================
  Files        1029     1319     +290     
  Lines      157251   182666   +25415     
==========================================
+ Hits       130764   147754   +16990     
- Misses      21322    29734    +8412     
- Partials     5165     5178      +13     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.16% <ø> (∅)
Go 83.13% <100.00%> (-0.06%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/task.go 87.05% <100.00%> (+0.02%) ⬆️

... and 318 files with indirect coverage changes

@wayblink
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 29, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 31, 2024

@wayblink cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@wayblink
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Oct 31, 2024

@wayblink cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wayblink
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 1, 2024

@wayblink cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Nov 1, 2024

@wayblink cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Nov 1, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 1, 2024
@sre-ci-robot sre-ci-robot merged commit d119a25 into milvus-io:master Nov 1, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants