Tasks: Track historic list of tasks configs #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Task.ts
Outdated
Comment on lines
466
to
485
| if (taskConfig.gasLimits) clonedTaskConfig.gasLimits = taskConfig.gasLimits | ||
| if (taskConfig.timeLock) clonedTaskConfig.timeLock = taskConfig.timeLock | ||
| if (taskConfig.connector) clonedTaskConfig.connector = taskConfig.connector | ||
| if (taskConfig.recipient) clonedTaskConfig.recipient = taskConfig.recipient | ||
| if (taskConfig.defaultTokenThreshold) clonedTaskConfig.defaultTokenThreshold = taskConfig.defaultTokenThreshold | ||
| if (taskConfig.defaultVolumeLimit) clonedTaskConfig.defaultVolumeLimit = taskConfig.defaultVolumeLimit | ||
| if (taskConfig.defaultTokenOut) clonedTaskConfig.defaultTokenOut = taskConfig.defaultTokenOut | ||
| if (taskConfig.defaultMaxSlippage) clonedTaskConfig.defaultMaxSlippage = taskConfig.defaultMaxSlippage | ||
| if (taskConfig.defaultDestinationChain) | ||
| clonedTaskConfig.defaultDestinationChain = taskConfig.defaultDestinationChain | ||
| if (taskConfig.defaultMaxBridgeFee) clonedTaskConfig.defaultMaxBridgeFee = taskConfig.defaultMaxBridgeFee | ||
| if (taskConfig.customTokenThresholds._id) | ||
| clonedTaskConfig.customTokenThresholds._id = taskConfig.customTokenThresholds._id | ||
| if (taskConfig.customVolumeLimits._id) clonedTaskConfig.customVolumeLimits._id = taskConfig.customVolumeLimits._id | ||
| if (taskConfig.customTokenOuts._id) clonedTaskConfig.customTokenOuts._id = taskConfig.customTokenOuts._id | ||
| if (taskConfig.customMaxSlippages._id) clonedTaskConfig.customMaxSlippages._id = taskConfig.customMaxSlippages._id | ||
| if (taskConfig.customDestinationChains._id) | ||
| clonedTaskConfig.customDestinationChains._id = taskConfig.customDestinationChains._id | ||
| if (taskConfig.customMaxBridgeFees._id) | ||
| clonedTaskConfig.customMaxBridgeFees._id = taskConfig.customMaxBridgeFees._id |
There was a problem hiding this comment.
Is it necessary to do the if thing? Can't we simply assign what ever it is stored there?
Also not sure what _id means
| export function loadOrCreateTaskConfig(task: Task, block: ethereum.Block): TaskConfig { | ||
| const taskConfigId = task.taskConfig | ||
|
|
||
| let taskConfig = TaskConfig.load(taskConfigId!) | ||
|
|
||
| if (taskConfig === null) { |
There was a problem hiding this comment.
This should be if (task.taskConfig === null)
Otherwise you are might try to load an entity with a null ID right above
| clonedTaskConfig.customMaxBridgeFees._id = taskConfig.customMaxBridgeFees._id | ||
| clonedTaskConfig.save() | ||
| task.taskConfig = clonedTaskConfig.id | ||
| taskConfig = clonedTaskConfig |
There was a problem hiding this comment.
You need to save task as well
|
Parking this PR for now until we have more frontend resources to make a use of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
Create new records of tasks, so can handle all historic tasks configs