Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High dose hook #182
High dose hook #182
Changes from all commits
20a323b
88c2868
6a4037a
7b1543b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this function is gonna be used only in
handle_high_dose_hook
then as a user I would prefer to see different error message. I know that this check fits here but I would move it tohandle_high_dose_hook
and there gave it different, more specific error message such as "NA values detected in the dilutions while handling high dose hook" or something similarThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess such a situation should not happen. In general, I think, it would mean that a standard curve sample has a missing dilution value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'd love to see a test in which we process a plate with high-hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it comes to the function
is.decreasing
the na handling is there because this function is located in the helpers.R and provided as a utility function to be used across the package.I will add a doc with an explanation about it to the
handle_high_dose_hook
and create a test specific for phenomenonThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to approve these changes. In general, if there were a problem with NA dilutions, it would also affect different parts of model creation. There are no specific exceptions thrown that could help track if there is standard curve sample without dilution.
I think, if @nizwant agrees we can approve these changes and optionally add this problem as a new issue, but I don't think that this is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to manipulate the plate object so that the standard curve sample would not have the dilution value, and it turns out that then it is read as a test sample instead. I am not sure how to enforce the behaviour that @nizwant wants to avoid other than through manual modification of plate object data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then it's fine
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.