Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reschedule next check date for rate limited feeds #2151

Closed
wants to merge 1 commit into from
Closed

Reschedule next check date for rate limited feeds #2151

wants to merge 1 commit into from

Conversation

fguillot
Copy link
Member

Do you follow the guidelines?

@shizunge
Copy link
Contributor

shizunge commented Nov 24, 2023 •
edited
Loading

Do you want to rebase this to #2222.

We can calculate the next check at in a single place, which seems more maintainable to me.

@shizunge
Copy link
Contributor

Do you think the following algorithm is better than adding a fixed interval?

Double the interval when we reach the limit.

oldNextCheckAt = f.NextCheckAt
oldInterval = now - oldNextCheckAt
newInterval = oldInterval * 2
f.NextCheckAt = now + newInterval

@shizunge shizunge mentioned this pull request Dec 1, 2023
Closed
2 tasks
@fguillot fguillot closed this Feb 17, 2024
@fguillot fguillot deleted the rate_limit branch February 17, 2024 21:36
@fguillot fguillot mentioned this pull request Oct 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fguillot @shizunge