Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELN: enhance unwanted repository filtering #1047

Merged
merged 1 commit into from
May 27, 2024

Conversation

yselkowitz
Copy link
Collaborator

We do not need to filter exim, esmtp, etc. here because we use hints in fedora-release to choose postfix as the provider of smtpdaemon. But we can use this filtering to block certain unwanted packages which are frequent culprits in pulling in hundreds or even a thousand-some more unwanted packages into ELN.

@tdawson
Copy link
Collaborator

tdawson commented Jan 5, 2024

I really think you want to keep excluding exim, esmtp, etc.. Sure fedora-release might give a hint, but I'd feel better keeping them in incase dnf can't take a hint. ;) And I don't see the harm in keeping them in.

@yselkowitz
Copy link
Collaborator Author

I really think you want to keep excluding exim, esmtp, etc.. Sure fedora-release might give a hint, but I'd feel better keeping them in incase dnf can't take a hint. ;) And I don't see the harm in keeping them in.

AFAICS it was an attempt to do what is better accomplished through hints, and since those were added to fedora-release, there have been no warnings related to these packages. At this point they would only show up if explicitly required, and would be no different than any other unwanted package.

@tdawson
Copy link
Collaborator

tdawson commented Jan 5, 2024

I don't have a strong opinion on exim, esmtp, etc. so if you think it's ok to take them out of excludes, I'm fine with that.
Other than that, LGTM.

@yselkowitz yselkowitz marked this pull request as draft January 9, 2024 23:47
@yselkowitz
Copy link
Collaborator Author

Package list is sane again, so let's try to hold off for now.

@yselkowitz yselkowitz force-pushed the repo-filtering branch 2 times, most recently from f5fb148 to cbf3d97 Compare January 19, 2024 16:42
@yselkowitz yselkowitz marked this pull request as ready for review May 27, 2024 19:16
Use this filtering to block certain unwanted packages which are frequent
culprits in pulling in hundreds or even a thousand-some more unwanted
packages into ELN.
@yselkowitz yselkowitz merged commit 29839fd into minimization:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants