Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualization-all: Add trustee-guest-components #1344

Merged
merged 1 commit into from
Jan 21, 2025
Merged

virtualization-all: Add trustee-guest-components #1344

merged 1 commit into from
Jan 21, 2025

Conversation

kostyanf14
Copy link
Contributor

@kostyanf14 kostyanf14 commented Jan 8, 2025 •
edited
Loading

Resolves: RHELPLAN-171373

@kostyanf14
Copy link
Contributor Author

cc: @uril

yselkowitz
yselkowitz requested changes Jan 8, 2025
View reviewed changes
configs/sst_virtualization-all.yaml Outdated Show resolved Hide resolved
@kostyanf14 kostyanf14 requested a review from yselkowitz January 8, 2025 19:00
yselkowitz
yselkowitz requested changes Jan 8, 2025
View reviewed changes
configs/sst_virtualization-all.yaml Outdated Show resolved Hide resolved
configs/sst_virtualization-all.yaml Outdated Show resolved Hide resolved
@kostyanf14 kostyanf14 requested a review from yselkowitz January 13, 2025 07:50
yselkowitz
yselkowitz approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will this be added to Fedora soon?

@uril
Copy link
Contributor

uril commented Jan 14, 2025

LGTM, will this be added to Fedora soon?

I hope it will. It got some preliminary reviews, but does not yet approved.
Review comments will be fixed in both Fedora and RHEL.

@kostyanf14
Copy link
Contributor Author

@yselkowitz When do you plan to merge this PR?

@yselkowitz
Copy link
Collaborator

Adding a package to CR before it has been added to a distro just results in a warning message for a "missing" package, so I would normally wait until it has been added to either Fedora or RHEL; neither has happened yet. You may continue with the PRP in the meantime.

@kostyanf14
Copy link
Contributor Author

@yselkowitz

You may continue with the PRP in the meantime.

Do I just mark RHELPLAN-171316 task as done and continue?

@yselkowitz
Copy link
Collaborator

That's a RHEL9 PRP; CR only tracks c10s/RHEL10 and ELN. You can mark that done, and when you get to that step in the RHEL10 PRP, this will cover that.

@kostyanf14
Copy link
Contributor Author

@yselkowitz We also started PRP for RHEL10. How to handle https://issues.redhat.com/browse/RHELPLAN-171373? Is updating this PR comment with the new bug ID enough?

@yselkowitz
Copy link
Collaborator

Yes, that's fine.

@yselkowitz
Copy link
Collaborator

FYI you don't need to keep rebasing for each change that lands before this, just let me know when the package has actually been added.

@kostyanf14 @yselkowitz
virtualization-all: Add trustee-guest-components
fd505b7 
Resolves: RHELPLAN-171373

Signed-off-by: Konstantin Kostiuk <[email protected]>
@yselkowitz yselkowitz merged commit fe816aa into minimization:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uril uril uril left review comments

@yselkowitz yselkowitz yselkowitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostyanf14 @uril @yselkowitz