Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinioAdminClient: add methods (attachPolicies, detachPolicies) #1626

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MinioAdminClient: add methods (attachPolicies, detachPolicies) #1626

wants to merge 3 commits into from

Conversation

jongmin-chung
Copy link
Contributor

@jongmin-chung jongmin-chung commented Feb 13, 2025 •
edited
Loading

resovles #1625

image

@jongmin-chung jongmin-chung changed the title Add attach or detach policies MinioAdminClient: add methods (attachPolicies, detachPolicies) Feb 13, 2025
@harshavardhana harshavardhana requested review from balamurugana and removed request for balamurugana February 13, 2025 08:34
balamurugana
balamurugana requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer https://github.com/minio/minio-py/blob/master/minio/minioadmin.py#L97 to implement ldap/builtin commands as they use same logic

@jongmin-chung
Copy link
Contributor Author

Should I include ldap command in that MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balamurugana balamurugana balamurugana requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jongmin-chung @balamurugana