-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test disabling enforce client side settings on athena workgroups #5678
base: main
Are you sure you want to change the base?
Conversation
Terraform Component 🧱:
|
Terraform Component 🧱:
|
@jacobwoffenden any ideas why the terraform workflow is failing? |
I don't think there's a problem with the code, I think the problem is because terraform doesn't allow us switch off "override client settings" |
|
@williamorrie any ideas on how this proceeds in Soumaya's absense? CC: @jhpyke |
Pull Request Objective
The Athena Primary workgroup does not enforce client side settings which means that IAM builder automatically grants access to the right folder : arn:aws:s3:::mojap-athena-query-dump/${aws:userid}/*"
We want to test the impact of not enforcing client https://docs.aws.amazon.com/athena/latest/ug/workgroups-settings-override.html on the new Airflow workgroups
Checklist
Note
Each items should be checked. Skipping below checks could delay your PR review!
and ensured that my code complies with it
used the
override-static-analysis
label, I've explained why)Additional Comments