MLPAB-2420 Show warnings on read the lpa when switching language and prevent donor changing it #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawx
changed the title
hawx
force-pushed
the
MLPAB-2420-dual-languages
branch
from
1631e7f to
7d427a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1762 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 286 287 +1
Lines 16669 16688 +19
=======================================
+ Hits 15856 15875 +19
Misses 642 642
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hawx
force-pushed
the
MLPAB-2420-dual-languages
branch
from
7d427a1 to
93bb935
Compare
hawx
force-pushed
the
MLPAB-2420-dual-languages
branch
from
93bb935 to
b5beeb2
Compare
hawx
force-pushed
the
MLPAB-2420-dual-languages
branch
from
f441572 to
85e925c
Compare
hawx
force-pushed
the
MLPAB-2420-dual-languages
branch
from
85e925c to
ffcccd5
Compare
hawx
force-pushed
the
MLPAB-2420-dual-languages
branch
from
ffcccd5 to
f3c280f
Compare
Also prevent donor from reading the lpa in a different language
hawx
force-pushed
the
MLPAB-2420-dual-languages
branch
from
f3c280f to
58caed3
Compare
acsauk
reviewed
Feb 7, 2025
| @@ -34,8 +34,7 @@ describe('Confirm your name', () => { | |||
|
|
|||
| cy.url().should('contain', '/your-name') | |||
| cy.checkA11yApp(); | |||
| cy.get('#f-last-name').clear(); | |||
| cy.get('#f-last-name').type('Smith'); | |||
| cy.get('#f-last-name').invoke('val', 'Smith'); | |||
There was a problem hiding this comment.
I think Cypress has got worse in the last version, this test was failing no matter how much I made sure it did this as I wanted.
This is just a selection of previously failed runs from today...
acsauk
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.