chore: convert helm to allowlist and tidy - probably breaks nginx whi… #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcharnley
force-pushed
the
chore/allow-list
branch
from
b2a7e00 to
6299033
Compare
markreesmoj
reviewed
Dec 11, 2024
| @@ -0,0 +1,15 @@ | |||
| minReplicaCount: 1 | |||
There was a problem hiding this comment.
add generic-service: at the top of these three files
markreesmoj
reviewed
Dec 11, 2024
| @@ -0,0 +1,23 @@ | |||
| ingress: | |||
There was a problem hiding this comment.
add generic-service: here
markreesmoj
reviewed
Dec 11, 2024
| --values - \ | ||
| --values ~/git/helm_deploy/prepare-a-case/values-live.yaml \ | ||
| --values ~/git/helm_deploy/prepare-a-case/values.yaml \ | ||
| --values ~/git/helm_deploy/prepare-a-case/values-<< parameters.env >>.yaml \ |
There was a problem hiding this comment.
rather than modify this, there is a deploy_env job in the hmpps orb which will do the trick.
https://github.com/ministryofjustice/court-case-matcher/blob/main/.circleci/config.yml#L144
|
Add this to Chart.yaml: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will break the ingest.yaml but I'm not sure what it's trying to do here.