Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add convertInMediaQuery feature #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DCLangX
Copy link

@DCLangX DCLangX commented Jul 14, 2023

大佬,我加了是否要在媒体查询里禁用转换的功能,不确定这个pr是不是有必要😂,因为注释禁用已经能满足了大部分需求,纯粹只是我个人需要🙃,我的项目中大量使用了媒体查询,加注释的话改的文件有点多,而且我这个逻辑可预见在多层媒体查询的嵌套里会有问题,不知道咋改🤡,太菜了,总之,如觉得无必要,请忽视即可,我可以自行构建使用

@hemengke1997
Copy link
Collaborator

感谢贡献!
这个功能很好,可能会有在媒体查询中禁用转换的需求
不过关于此pr,我有一些建议:

  1. 把此功能收敛到字段 convertInMediaQuery
  2. 完善在多层媒体查询中可以实现禁用转换的功能
  3. 优化判断条件,把skipTag统一处理
  4. 提取硬编码到外部常量中,比如 atRule:media/ media

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants