Octopoes combined schedulers integration #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbruinsslot
changed the base branch from
main
to
poc/mula/combined-schedulers
jpbruinsslot
commented
Jan 8, 2025
| @@ -26,6 +26,7 @@ class ScanProfileMutation(BaseModel): | |||
| operation: OperationType | |||
| primary_key: str | |||
| value: AbstractOOI | None = None | |||
| client_id: str | |||
There was a problem hiding this comment.
I named this client_id since organisations are referred to as clients in octopoes. So not sure if this should be organisation or client
…ed-schedulers-integration
jpbruinsslot
merged commit 03b75f7
into
poc/mula/combined-schedulers
22 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Main PR: #3839
Issue link
Closes #3838