Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/reuse report ooi entities #4047

Open
wants to merge 119 commits into
base: main
Choose a base branch
from
Open

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Jan 24, 2025

Changes

This PR changes the data structure around reporting. The main changes have been described in #3729, but this also includes:

  • A new Bytes API endpoint where we can request multiple raw files at once
  • An Octopoes API update where we now add scan profiles to the load_bulk endpoint for OOIs

Note that the tests are still a work in progress in Rocky!

Issue link

Closes #3729

Demo

Scherm­afbeelding 2025-01-24 om 13 20 56 Scherm­afbeelding 2025-01-24 om 13 21 31 Scherm­afbeelding 2025-01-24 om 13 21 47

QA notes

The main changes are around reporting, so please verify that:

  • Scheduling (aggregate) reports still works properly, especially given the other updates around schedule once
  • The report overview pages still work
  • You see the right amount of asset reports
  • You can render both aggregate, concatenated, and single asset reports
  • Of course, that the jobs still run properly given the changes in Octopoes and Bytes!

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Donnype and others added 30 commits December 5, 2024 15:54
WIP fix integration tests for octopoes
Update references to report_types where we actually now new asset_report_types
Style
Rieven and others added 28 commits January 22, 2025 16:52
…kat-coordination into fix/reuse-report-ooi-entities
…kat-coordination into fix/reuse-report-ooi-entities
Rocky integration test setup fix
Make report_type not nullable
Make recipe not nullable
Fix octopoes load bulk again
…kat-coordination into fix/reuse-report-ooi-entities
@Donnype Donnype requested a review from a team as a code owner January 24, 2025 12:24
@Donnype Donnype added the report label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] We should use a ReportOOI entity per Report, or update a Report in-place and traverse the history API
3 participants