-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/reuse report ooi entities #4047
Open
Donnype
wants to merge
119
commits into
main
Choose a base branch
from
fix/reuse-report-ooi-entities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP fix integration tests for octopoes
…nto fix/reuse-report-ooi-entities
Update references to report_types where we actually now new asset_report_types Style
…/reuse-report-ooi-entities
…/reuse-report-ooi-entities
…kat-coordination into fix/reuse-report-ooi-entities
…nto fix/reuse-report-ooi-entities
…kat-coordination into fix/reuse-report-ooi-entities
Rocky integration test setup fix
…nto fix/reuse-report-ooi-entities
…nvws/nl-kat-coordination into fix/reuse-report-ooi-entities
Make report_type not nullable Make recipe not nullable
…nto fix/reuse-report-ooi-entities
Fix octopoes load bulk again
…kat-coordination into fix/reuse-report-ooi-entities
…nto fix/reuse-report-ooi-entities
…nvws/nl-kat-coordination into fix/reuse-report-ooi-entities
…nto fix/reuse-report-ooi-entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the data structure around reporting. The main changes have been described in #3729, but this also includes:
Note that the tests are still a work in progress in Rocky!
Issue link
Closes #3729
Demo
QA notes
The main changes are around reporting, so please verify that:
Code Checklist
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.