-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows/dkml: opam install with deps-only and with-test only packages to test, deps-only for only build #198
Conversation
the std_cflags are properly picked up (in contrast to #137 (comment)), also this fixes #137 (comment) remaining is the following issue, on windows 64 bit systems, the fiat 32 bit versions are used (reason behind this is that 128bit unsigned integers are not available) -- now with our pre-computed tables, this results in an error. I guess on a windows 64 bit system, using the 32 bit tables is fine. any other opinion @Firobe @jonahbeckford ? I added that in 975a881 (but unfortunately our mirage-crypto-ec tests aren't running on dkml/windows since mirage-crypto-pk and asn1-combinators don't work there (gmp/zarith). |
5589386
to
65e0b63
Compare
Thanks to #200, we can now run mirage-crypto-ec tests. Unfortunately, they fail:
It is not entirely clear to me, why, though. The assetion in question: let to_ed25519_keys (key : eddsa_key) =
let priv_cs = Cstruct.of_string key.sk
and pub_cs = Cstruct.of_string key.pk
in
match Ed25519.priv_of_cstruct priv_cs, Ed25519.pub_of_cstruct pub_cs with
| Ok priv, Ok pub ->
assert (Cstruct.equal Ed25519.(pub_to_cstruct (pub_of_priv priv)) pub_cs); (* that's the failing one *)
priv, pub
| _ -> assert false This means that the |
to be clear, I don't have any further energy and time to look deeper into "CL.EXE" and what goes wrong. If someone can pick this up, best with an actual setup to have quick compile-test-edit cycles, that'd be amazing. I propose to do some printf debugging (looking where If there's no interest/time by others, I plan to revert the DKML changes in the main branch to cut a mirage-crypto release. |
I have no time to do this at the moment. While I think it would be better just to mark the |
… to test, deps-only for only build
ok, I removed mirage-crypto-ec from the windows-dkml-ci script. plan to merge this when CI is green. I have no idea @jonahbeckford about your plans to use mirage-crypto on dkml/windows -- but I'm sure your suggestion "remove mirage-crypto-ec from the build" fits your needs. I'll open an issue about the mirage-crypto-ec and dkml. |
//cc @jonahbeckford