Fix the unintentional movement caused by snapping correction #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction is enabled. This issue causes unintentional movement, especially when using grouped nodes such as the comment node.
|
Hi, thanks for your contribution, but the fix also has a side effect. It prevents the snapping when moving the selection only in one axis. |
Oh you're right, it should be || instead of &&. |
|
Looks good. Please update the changelog with the fix before I merge it. Thanks! |
Thanks for the review. Updated the changelog file. |
miroiu
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description of the Change
Check the actual movement before apply the snapping correction.
When the snapping correction is enabled, the graph attempts to align the nodes to the grids.
However, even if a user merely selects a node, it might still move and snap to the grid.
Furthermore, when using grouped nodes, such as comment in the playground example, selecting the comment can inadvertently select many nodes. This can lead to several unintentional movements.
🐛 Possible Drawbacks
Are there any possible side-effects or negative impacts with this code change?
I think not.
Users who wish to adjust nodes based on grid size can easily nudge them slightly to achieve the desired alignment.