[mirotalkbro] - #10 refactoring

miroslavpejic85 · Jan 20, 2025 · e5c99c1 · e5c99c1
1 parent 3cb5642
commit e5c99c1
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 22 deletions.
diff --git a/app/server.js b/app/server.js
@@ -8,7 +8,7 @@
  * @license For open source under AGPL-3.0
  * @license For private project or commercial purposes contact us at: [email protected]
  * @author  Miroslav Pejic - [email protected]
- * @version 1.1.17
+ * @version 1.1.18
  */
 
 require('dotenv').config();

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "mirotalkbro",
-    "version": "1.1.17",
+    "version": "1.1.18",
     "description": "P2P WebRTC audio, video and screen live broadcast",
     "main": "app/server.js",
     "scripts": {

diff --git a/public/css/common.css b/public/css/common.css
@@ -206,6 +206,10 @@ input:checked + .slider:before {
     padding: 0.5rem;
 }
 
+a {
+    color: #0969b4;
+}
+
 .swal2-title,
 .swal2-content {
     background-color: var(--panel-color) !important;

diff --git a/public/js/broadcast.js b/public/js/broadcast.js
@@ -1112,7 +1112,7 @@ function handleMediaDeviceError(error) {
     if (screenShareEnabled) {
         toggleScreen();
     } else {
-        handleMediaStreamError('Audio/Video', error);
+        handleMediaStreamError(error);
     }
 }
 

diff --git a/public/js/utils.js b/public/js/utils.js
@@ -111,7 +111,7 @@ function stopVideoTrack(mediaStream) {
     }
 }
 
-function handleMediaStreamError(mediaStreamType, error) {
+function handleMediaStreamError(error) {
     let errorMessage = error;
     let shouldHandleGetUserMediaError = true;
 
@@ -138,25 +138,11 @@ function handleMediaStreamError(mediaStreamType, error) {
             break;
     }
 
-    let popupContent = `
-    <ul style="text-align: left">
-        <li>Media type: ${mediaStreamType}</li>
-        <li>Error name: ${error.name}</li>
-        <li>
-            Error message:
-            <p style="color: red">${errorMessage}</p>
-        </li>`;
-
     if (shouldHandleGetUserMediaError) {
-        popupContent += `
-        <li>Common: <a href="https://blog.addpipe.com/common-getusermedia-errors" target="_blank">getUserMedia errors</a></li>`;
+        errorMessage += `
+        Check the common <a href="https://blog.addpipe.com/common-getusermedia-errors" target="_blank">getUserMedia errors</a></li>`;
     }
-
-    popupContent += `
-        </ul>
-    `;
-
-    popupMessage('warning', 'Access denied', popupContent, 'center');
+    popupMessage('warning', 'Ops', errorMessage, 'center');
 }
 
 function saveDataToFile(dataURL, fileName) {

diff --git a/public/js/viewer.js b/public/js/viewer.js
@@ -403,7 +403,7 @@ async function getStream() {
         return stream;
     } catch (error) {
         console.error('Failed to access media devices:', error.message);
-        handleMediaStreamError('Audio/Video', error);
+        handleMediaStreamError(error);
         hideVideoAudioButtons();
         return null;
     }