Adding support for POST requests on the importer #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,8 @@ | |||
| * extract - a method to pass raw data through before handing back to parser. | |||
| * dataType - ajax datatype | |||
| * jsonp - true if it's a jsonp request, false otherwise. | |||
| * type - wether to do a post or a get request (defaults to 'GET') | |||
| * postData - The post data to send with the request | |||
There was a problem hiding this comment.
Can you change the name of this property to 'data' which is consistent with the parameter types used in jQuery (and thus are well known.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for POST requests on remote importers (by passing the
typeandpostDataparameters to the importer). It's a small change which might help?