Prevent invalid ActiveRecord check against constant (Shopify#401)

missive · Jun 13, 2024 · 9be01d0 · 9be01d0
1 parent 02c6014
commit 9be01d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/ruby_lsp/ruby_lsp_rails/server.rb b/lib/ruby_lsp/ruby_lsp_rails/server.rb
@@ -143,6 +143,7 @@ def active_record_model?(const)
         !!(
           const &&
             defined?(ActiveRecord) &&
+            const.is_a?(Class) &&
             ActiveRecord::Base > const && # We do this 'backwards' in case the class overwrites `<`
           !const.abstract_class?
         )

diff --git a/test/ruby_lsp_rails/server_test.rb b/test/ruby_lsp_rails/server_test.rb
@@ -24,6 +24,11 @@ class ServerTest < ActiveSupport::TestCase
     assert_nil(response.fetch(:result))
   end
 
+  test "returns nil if constant is not a class" do
+    response = @server.execute("model", { name: "RUBY_VERSION" })
+    assert_nil(response.fetch(:result))
+  end
+
   test "doesn't fail if the class overrides `<`" do
     class TestClassWithOverwrittenLessThan
       class << self