Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revises the Node CI #70

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Revises the Node CI #70

wants to merge 8 commits into from

Conversation

Berkmann18
Copy link
Collaborator

@Berkmann18 Berkmann18 commented Jun 1, 2020

As it's now unwise to get Cypress to target the production URL over a local one (especially in PRs), it now tests against http://localhost:1234 built by the CI itself.

@Berkmann18 Berkmann18 changed the title [WIP] Revises the Node CI Revises the Node CI Jun 1, 2020
@Berkmann18 Berkmann18 changed the base branch from master to fixes-webgl-backend-import June 1, 2020 23:48
@Berkmann18
Copy link
Collaborator Author

I have a feeling, it would need Conv2D kernel (#43) to work properly.
image

@amirhmk
Copy link
Collaborator

amirhmk commented Oct 22, 2020

@Berkmann18 I think for the dev test to pass you have to change

cy.visit('/dev'); -> cy.visit('/dev.html');

Base automatically changed from fixes-webgl-backend-import to master October 22, 2020 15:54
@Berkmann18
Copy link
Collaborator Author

@amirhmk Does that work on your hand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants