fix: Inconsistent selection behavior in project explorer #3341 #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@SusanRatiLane, could you please review my pull request? |
SusanRatiLane
requested changes
Jan 27, 2025
There was a problem hiding this comment.
I'm not clear why we need a new css class. For one thing, the highlight color in Classic is yellow, and the highlight color in Neo is purple. This makes them both yellow.
What does ode-ProjectRowHighlighted look like in Ya.css (Classic) and neo.css (Neo)? Can they be fixed to highlight the rows correctly?
d1vyanshu-kumar
force-pushed
the
Inconsistent-selection-behavior
branch
from
a6a5756 to
3943fea
Compare
|
@SusanRatiLane, could you please review it now? I've made some necessary changes to address the issue mentioned earlier. Previously, I thought that styles conflicting with ode-ProjectRowHighlighted might override the intended styles. However, I realized that I was mistaken and made the corrections |
Screen.Recording.2025-01-28.at.6.02.55.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
mastermasteras the baseWhat does this PR accomplish?
setSelectedmethod inProjectFolderto add and removeode-ProjectRowHighlightedandhighlight-folderRowstyles.background: background-color;from CSS..highlight-folderRowCSS class withbackground-color: #fff6c3;.Fixes #3341