fix: Inconsistent selection behavior in project explorer #3341

[d1vyanshu-kumar]

• My code follows the:
  • Google Java style guide (for .java files)
  • Google JavaScript style guide (for .js files)
• ant tests passes on my machine

If your code changes how something works on the device (i.e., it affects the companion):

• I branched from master
• My pull request has master as the base

What does this PR accomplish?

• Updated setSelected method in ProjectFolder to add and remove ode-ProjectRowHighlighted and highlight-folderRow styles.
• Removed background: background-color; from CSS.
• Added .highlight-folderRow CSS class with background-color: #fff6c3;.

Fixes #3341

[AppInventorWorkerBee]

Can one of the admins verify this patch?

[d1vyanshu-kumar]

@SusanRatiLane, could you please review my pull request?
Thanks!

[SusanRatiLane]

I'm not clear why we need a new css class. For one thing, the highlight color in Classic is yellow, and the highlight color in Neo is purple. This makes them both yellow.

What does ode-ProjectRowHighlighted look like in Ya.css (Classic) and neo.css (Neo)? Can they be fixed to highlight the rows correctly?

[d1vyanshu-kumar]

@SusanRatiLane, could you please review it now? I've made some necessary changes to address the issue mentioned earlier. Previously, I thought that styles conflicting with ode-ProjectRowHighlighted might override the intended styles. However, I realized that I was mistaken and made the corrections

appinventor-sources/appinventor/appengine/src/com/google/appinventor/client/explorer/folder/ProjectFolder.java

Line 170 in 3390576

container.addStyleName("ode-ProjectRowHighlighted");

appinventor-sources/appinventor/appengine/src/com/google/appinventor/client/explorer/youngandroid/ProjectListItem.java

Line 81 in 3390576

container.addStyleName("ode-ProjectRow-Highlighted");

[d1vyanshu-kumar]

;

Screen.Recording.2025-01-28.at.6.02.55.PM.mov