Update deletion for caching #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
force-pushed
the
feature/update-deletion-for-caching
branch
3 times, most recently
from
d1d43ff
to
812a3f9
Compare
Davidson-Souza
changed the title
kcalvinalvin
reviewed
Nov 3, 2022
There was a problem hiding this comment.
ACK 812a3f9
Tested the new test cases. While they all pass the first one shouldn't have any proof_hashes. Everything else looks good.
test_values/cache_tests.json
Outdated
| "dbc1b4c900ffe48d575b5da5c638040125f65db0fe3e24494b76ea986457d986", | ||
| "084fed08b978af4d7d196a7446a86b58009e636b611db16211b65a9aadff29c5" | ||
| ], | ||
| "proof_hashes": [ |
There was a problem hiding this comment.
The verification for this proof will pass since it needs no proof hashes to verify [0, 1, 2, 3] in a forest with 6 leaves. I'm not sure if we should treat these as a failure but since putting in any hashes here will pass the tests.
But we should really do it the correct way and have nothing here as the proofs.
There was a problem hiding this comment.
I'm not sure where this hashes came from. I removed them.
Now deletion returns all modified positions, so we can update our proofs by replacing old positions with their new values.
Davidson-Souza
force-pushed
the
feature/update-deletion-for-caching
branch
from
812a3f9
to
3ac22ed
Compare
|
ACK 3ac22ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #13 and #15; hence it's marked as draft.This finalizes the implementation of required support data for proof update, now we also return which nodes have been updated during deletion.
Required for #12.