Implement Pollard #27
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
force-pushed
the
feature/pollard
branch
2 times, most recently
from
d204bb0
to
b49021c
Compare
Davidson-Souza
force-pushed
the
feature/pollard
branch
3 times, most recently
from
e23b64b
to
906adbf
Compare
Implement basic element addition for Pollard
Davidson-Souza
force-pushed
the
feature/pollard
branch
from
906adbf
to
735afdd
Compare
Davidson-Souza
force-pushed
the
feature/pollard
branch
2 times, most recently
from
eaa4323
to
80b1338
Compare
Pollard is a middle-ground between full tree and Stump that allows holding only a subset of UTXOs, while still allowing proving those elements. This implementation only allows for full pollards, where all leaves are present. Allowing partial pollard will be accomplished later. The implementation uses interior mutability to work. A Pollard is different from a normal Binary Tree because nodes points to it's sibling, not their children. This makes recursive algoritms more evolved, specially during deletions. This implementation is all iteractive, and carefully uses interior mutability with Cell and RefCell. Those smart pointers allows runtime borrow checking, if some of the Borrowing Rules is broken, it panics. Here, we take care of not holding reference to the interior of a Cell or RefCell for too log, and not passing `mut ref` arround. Only a few functions with very limited scope can use `mut ref`s. A extensible collection of tests is also provided, to check for code correctness and soundness.
Davidson-Souza
force-pushed
the
feature/pollard
branch
from
80b1338
to
bbdd8ab
Compare
|
Is this ready for review? |
Davidson-Souza
pushed a commit
to Davidson-Souza/rustreexo
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pollard is a data structure that holds prune-able trees to represent the current accumulator, thus, creating a client that may prove arbitrary UTXOs. This PR implements a Pollard struct in Rust with add/del methods.
The implementation is capable of passing our test cases used for stump. There's also a wide range of tests for different aspects of a Pollard.
All commits should compile and run on its own, modulo some warnings in the first ones.