Skip to content

Commit

Permalink
Disable debug make build due to config.status write out freeze bug on…
Browse files Browse the repository at this point in the history
… github actions

minor other readme / gen fixes
  • Loading branch information
mitchcapper committed Jan 14, 2025
1 parent bf64aea commit c16f1f5
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ highlight
libhsts
libpsl
libtasn1
make
make: -NoDebug
openssl
patch
pcre2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tool_make_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ jobs:
uses: ./.github/workflows/tool_build.yml
with:
ToolName: make

NoDebugBuild: true
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ In short only msys2 needs to be installed along with the Visual Studio Build Env

## MSYS2

https://www.msys2.org/ MSYS2 is a linux sub-system for windows but unlike cygwin largely works not to simulate all things linux but to provide the infrastructure to do native windows compiling. Msys does use some cygwin packages for its env. We don't need any packages installed from the UI just launch a shell once installed or unzipped and then run: `pacman -S pkg-config make gperf rsync autoconf wget gettext-devel automake autogen texinfo git bison python autoconf-archive libtool flex ppatch unzip`. For compiling we use a special way to enter the shell to make sure things we need are available (See Shell Launch below). If you have an existing msys instance and already have various developer tools installed it may screw builds up. Configure scripts look for certain things and either fallback or try alternates when not found. If you have something like GCC or msys/cygwin developer headers for certain packages installed these may take preference and either prevent builds from working, or require additional dlls to work. The best solution is just create a second msys2 install just for this extract the msys2 archive to an alternate path and use the proper launcher to enter that msys and all will be well. Similarly it is possible that if you have certain tools in your default path for windows say gcc or some other app configure looks for you may find again strange behavior. This can be harder to fix as you will need to edit your shell launch script to remove those paths from your path before starting. I would highly recommend adding the environmental variable `MSYS2_ARG_CONV_EXCL="*")
https://www.msys2.org/ MSYS2 is a linux sub-system for windows but unlike cygwin largely works not to simulate all things linux but to provide the infrastructure to do native windows compiling. Msys does use some cygwin packages for its env. We don't need any packages installed from the UI just launch a shell once installed or unzipped and then run: `pacman -S pkg-config make gperf rsync autoconf wget gettext-devel automake autogen texinfo git bison python autoconf-archive libtool flex patch unzip`. For compiling we use a special way to enter the shell to make sure things we need are available (See Shell Launch below). If you have an existing msys instance and already have various developer tools installed it may screw builds up. Configure scripts look for certain things and either fallback or try alternates when not found. If you have something like GCC or msys/cygwin developer headers for certain packages installed these may take preference and either prevent builds from working, or require additional dlls to work. The best solution is just create a second msys2 install just for this extract the msys2 archive to an alternate path and use the proper launcher to enter that msys and all will be well. Similarly it is possible that if you have certain tools in your default path for windows say gcc or some other app configure looks for you may find again strange behavior. This can be harder to fix as you will need to edit your shell launch script to remove those paths from your path before starting. I would highly recommend adding the environmental variable `MSYS2_ARG_CONV_EXCL="*")

### Avoid Packages
Msys should generally have a few tools NOT installed or not in the path including: cmake, any compilers other than MSVC (unless you want to use an alternate one). There also some executables best not to be in your path (see tips & tricks below).
Expand Down
2 changes: 1 addition & 1 deletion vs_debug_help/coreutils_create.bat
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dotnet-script "%WLB_SCRIPT_FOLDER%\vs_debug_help\DebugProjGen.csx" --exe ls --libraries lib/libcoreutils.a --include_paths . --compile "src/ls.c" src/remove.c src/copy.c src/cp-hash.c src/force-link.c src/selinux.c src/ls-ls.c gnulib/lib/fstat.c gnulib/lib/fts.c gnulib/lib/fstat.c gnulib/lib/readdir.c gnulib/lib/open-safer.c gnulib/lib/stat-w32.c gnulib/lib/stat.c gnulib/lib/readlink.c gnulib/lib/readlinkat.c gnulib/lib/filemode.c src/copy.c
dotnet-script "%WLB_SCRIPT_FOLDER%\vs_debug_help\DebugProjGen.csx" --exe ls --libraries lib/libcoreutils.a --include_paths . --compile "src/ls.c" src/relpath.c src/remove.c src/copy.c src/cp-hash.c src/force-link.c src/selinux.c src/ls-ls.c gnulib/lib/fstat.c gnulib/lib/fts.c gnulib/lib/fstat.c gnulib/lib/readdir.c gnulib/lib/open-safer.c gnulib/lib/stat-w32.c gnulib/lib/stat.c gnulib/lib/readlink.c gnulib/lib/readlinkat.c gnulib/lib/filemode.c src/copy.c


0 comments on commit c16f1f5

Please sign in to comment.