Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers changes which simplify the use of the
DataSource
class for:DataSource
s in PZThe primary changes I made were to:
DataSource
,AbstractDataSource
, andValidationDataSource
) down to a singleDataSource
class__len__()
andget_item()
This in turn led to a number of other changes / simplifications in the code including:
datasource
directly in the scan operators (both logical and physical) instead ofdataset_id
source_id
-->source_idx
everywhere (this eliminated some weird renaming logic)Finally, I added a large set of documentation for the
DataSource
class(es)