-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardize MITx Online support email address #2363
base: main
Are you sure you want to change the base?
Conversation
[email protected] is a email support address that works. It forwards to ZenDesk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Received two email responses when I emailed the address. One referencing MITx Online and the other mentioning MicroMasters
I got that too. I think it's a configuration issue in ZenDesk. I don't think that should block this change though? |
No, not a blocker, but I would fix the Zendesk side and verify it prior to merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See note. Since this is just the from address I can approve this and we can then fix the config settings for the from address in a separate PR if you'd like - email programs should respect the Reply-To setting so the From address is important but less so.
@@ -188,9 +188,9 @@ | |||
"MITX_ONLINE_ADMIN_EMAIL": "[email protected]", | |||
"MITX_ONLINE_DB_CONN_MAX_AGE": "0", | |||
"MITX_ONLINE_DB_DISABLE_SSL": "True", # pgbouncer buildpack uses stunnel to handle encryption" | |||
"MITX_ONLINE_FROM_EMAIL": "MITx Online <support@mitxonline.mit.edu>", | |||
"MITX_ONLINE_FROM_EMAIL": "MITx Online <mitxonline-[email protected]>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this isn't the setting that needs to change. Did some digging locally and there's one called MAILGUN_FROM_EMAIL
that appears to be the one we use - for some reason I don't see this at all in the config here. (It does exist in Heroku, though.) Changing that has the desired effect.
On RC this is set to MITx Online <[email protected]>
and on prod this is MITx Online <[email protected]>
.
(The reply-to setting is fine and is arguably more important.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove MITX_ONLINE_FROM_EMAIL
then, and add MAILGUN_FROM_EMAIL
?
@jkachel I don't understand. Should we add another setting, for I don't suppose we could make a change to code and get rid of some of these (apparently) duplicative settings? |
I think we have two potential paths here:
In my mind, the second option is the proper option - having there be extra settings is confusing and the |
0c53ebe
to
b98c3b3
Compare
What are the relevant tickets?
fixes https://github.com/mitodl/hq/issues/4051
Description (What does it do?)
[email protected] is a email support address that works. It forwards to ZenDesk.
AFAIK, there is no mail server at mitxonline.mit.edu, so [email protected] cannot work.
How can this be tested?
~~Apply for financial aid on a course on mitxonline and inspect the status email that is returned. ~~
Even easier: enroll in any course for free, e.g. https://mitxonline.mit.edu/courses/course-v1:MITxT+8.02.3x/
The return address on the enrollment email is currently [email protected]. After this change it should be [email protected]