Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize MITx Online support email address #2363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pdpinch
Copy link
Member

@pdpinch pdpinch commented Apr 19, 2024

What are the relevant tickets?

fixes https://github.com/mitodl/hq/issues/4051

Description (What does it do?)

[email protected] is a email support address that works. It forwards to ZenDesk.

AFAIK, there is no mail server at mitxonline.mit.edu, so [email protected] cannot work.

How can this be tested?

~~Apply for financial aid on a course on mitxonline and inspect the status email that is returned. ~~

Even easier: enroll in any course for free, e.g. https://mitxonline.mit.edu/courses/course-v1:MITxT+8.02.3x/

The return address on the enrollment email is currently [email protected]. After this change it should be [email protected]

[email protected] is a email support address that works. It forwards to ZenDesk.
@pdpinch pdpinch changed the title standardize support email address standardize MITx Online support email address Apr 22, 2024
Copy link
Contributor

@shaidar shaidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Received two email responses when I emailed the address. One referencing MITx Online and the other mentioning MicroMasters

@pdpinch
Copy link
Member Author

pdpinch commented Apr 23, 2024

Received two email responses when I emailed the address. One referencing MITx Online and the other mentioning MicroMasters

I got that too. I think it's a configuration issue in ZenDesk. I don't think that should block this change though?

@shaidar
Copy link
Contributor

shaidar commented Apr 23, 2024

No, not a blocker, but I would fix the Zendesk side and verify it prior to merging this.

@jkachel jkachel self-assigned this Apr 23, 2024
Copy link
Contributor

@jkachel jkachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note. Since this is just the from address I can approve this and we can then fix the config settings for the from address in a separate PR if you'd like - email programs should respect the Reply-To setting so the From address is important but less so.

@@ -188,9 +188,9 @@
"MITX_ONLINE_ADMIN_EMAIL": "[email protected]",
"MITX_ONLINE_DB_CONN_MAX_AGE": "0",
"MITX_ONLINE_DB_DISABLE_SSL": "True", # pgbouncer buildpack uses stunnel to handle encryption"
"MITX_ONLINE_FROM_EMAIL": "MITx Online <support@mitxonline.mit.edu>",
"MITX_ONLINE_FROM_EMAIL": "MITx Online <mitxonline-[email protected]>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this isn't the setting that needs to change. Did some digging locally and there's one called MAILGUN_FROM_EMAIL that appears to be the one we use - for some reason I don't see this at all in the config here. (It does exist in Heroku, though.) Changing that has the desired effect.

On RC this is set to MITx Online <[email protected]> and on prod this is MITx Online <[email protected]>.

(The reply-to setting is fine and is arguably more important.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove MITX_ONLINE_FROM_EMAIL then, and add MAILGUN_FROM_EMAIL ?

@pdpinch
Copy link
Member Author

pdpinch commented Apr 26, 2024

@jkachel I don't understand. Should we add another setting, for MAILGUN_FROM_EMAIL or is there some other change that you're recommending?

I don't suppose we could make a change to code and get rid of some of these (apparently) duplicative settings?

@jkachel
Copy link
Contributor

jkachel commented Apr 26, 2024

@jkachel I don't understand. Should we add another setting, for MAILGUN_FROM_EMAIL or is there some other change that you're recommending?

I don't suppose we could make a change to code and get rid of some of these (apparently) duplicative settings?

I think we have two potential paths here:

  • Add MAILGUN_FROM_EMAIL here and set it appropriately; this will fix the issue immediately, and then we can remove the MITX_ONLINE_FROM_EMAIL setting from the MITx Online app.
  • Continue with the change as-is (settingMITX_ONLINE_FROM_EMAIL to the proper email address), then update the app to use MITX_ONLINE_FROM_EMAIL over MAILGUN_FROM_EMAIL.

In my mind, the second option is the proper option - having there be extra settings is confusing and the MITX_ONLINE_FROM_EMAIL setting matches the other app-specific email settings. But the first route will fix the issue at hand faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants