Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removing dead code #379

Merged
merged 1 commit into from
Sep 11, 2024
Merged

chore: Removing dead code #379

merged 1 commit into from
Sep 11, 2024

Conversation

alilleybrinker
Copy link
Collaborator

We have a lot of dead code left over from prior work, especially from the transition to the plugin system. This commit is the start of removing a lot of that dead code while ensuring everything still compiles and tests still pass.

We have a lot of dead code left over from prior work, especially
from the transition to the plugin system. This commit is the
start of removing a lot of that dead code while ensuring everything
still compiles and tests still pass.

Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
@alilleybrinker
Copy link
Collaborator Author

By my count, even after this PR, there are 80 instances of allow-unused or allow-dead-code in the codebase.

@alilleybrinker alilleybrinker self-assigned this Sep 10, 2024
@alilleybrinker alilleybrinker added the type: refactor Changes to code structure that do not impact functionality label Sep 10, 2024
@alilleybrinker alilleybrinker added this to the 3.7.0 milestone Sep 10, 2024
@mchernicoff mchernicoff merged commit 9bee656 into main Sep 11, 2024
9 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/dead-code branch September 13, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Changes to code structure that do not impact functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants