#rel() macro for relative paths in policy files #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile location Signed-off-by: jlanson <[email protected]>
Signed-off-by: jlanson <[email protected]>
j-lanson
added
type: bug
mchernicoff
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #764 .
This PR adds a macro to the policy files, namely
#rel()which goes around a string and re-interprets it as a path relative to the parent of the policy file. This way, the policy file stored in./configcan refer to the other files in the folder just by name, such asorg-file #rel("Orgs.kdl").This is necessary to fix the bug encountered in #752 . Turns out, until now probably most of our docker and binary releases would not "just work" for new people.
This PR does not address providing the
#rel()functionality to config files (Hipcheck.toml), doing so is a lot larger of a lift. So going forward, using the default config file will still not work out of the box, but we plan to deprecate config files soon anyway.@alilleybrinker I would be in favor of getting this PR and #751 merged in and releasing a
hipcheck-v3.9.1so we have a working latest version prior to3.10release date.