Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README file to use actions v4 #71

Merged
merged 24 commits into from
Jan 10, 2025
Merged

Update README file to use actions v4 #71

merged 24 commits into from
Jan 10, 2025

Conversation

jtquach1
Copy link
Contributor

Updating actions v3 to v4 since v3 will be deprecated 1/30/2025

@jtquach1
Copy link
Contributor Author

jtquach1 commented Dec 30, 2024 •
edited
Loading

The resolution of the failing npm test might be blocked until the next release of SAF CLI since there is a commit on main of saf that downgrade oclif/core which resolves the bug with it.

Amndeep7 added 22 commits January 3, 2025 19:49
@Amndeep7
Merge branch 'main' into update-actions-to-v4
91d47f8
@Amndeep7
wonder if everything still works if we move this to 22
a9ddb00 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
test windows
9caed5e 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
debugging
047891f 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
we should be testing against the latest here
5fa5ce2 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
use branch that i'm testing
0e7c3a0 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
apparently node22 ain't out yet
46f32a8 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
more granule console logs
7ad1aba 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
need debugging output from linux as well
ba474d3 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
confirmed that process.env.HOME does not exist on windows side, found…
2e729aa 
… a new github envvar that might do what we need it to do

Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
does this var exist?
13b7ab2 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
reorder console logs
d2bf8fe 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
var i tried to use doesn't exist, seeing if i can do a more generic w…
633a520 
…orkaround

Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
comment syntax lol
09e66a8 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
try relative path approach
e84e2b1 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
logs
30afbcb 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
fix relative path
b91d5f2 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
actually fix
b222ed6 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
get rid of envvar that fails on window every time and also print out …
7d89e24 
…tree

Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
get rid of logging
f49ce78 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
behavior was split out into two different flags
19a71a7 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
don't point at wip branch anymore
f64c5c1 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7 Amndeep7 merged commit fcfe678 into main Jan 10, 2025
1 of 3 checks passed
@Amndeep7 Amndeep7 deleted the update-actions-to-v4 branch January 10, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Amndeep7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtquach1 @Amndeep7