bump dependencies #114
bump dependencies #114
Conversation
elenz97
force-pushed
the
bump/goharbor-client
branch
from
03e2aa9 to
00d563b
Compare
elenz97
force-pushed
the
bump/goharbor-client
branch
from
00d563b to
46ce4d6
Compare
| @@ -20,7 +20,7 @@ func BuildClient(ctx context.Context, cl client.Client, | |||
| sec := &corev1.Secret{} | |||
|
|
|||
| err := cl.Get(ctx, client.ObjectKey{ | |||
| Name: harbor.Name + "-harbor-core", | |||
| Name: harbor.Name + "-core", | |||
There was a problem hiding this comment.
Isn't this breaking AF? With an existing registry, how is ensured that harbor.Name + "-harbor-core" is moved to harbor.Name + "-core"?
There was a problem hiding this comment.
With the chart change in goharbor/harbor-helm@db7b7c1#diff-87d68c754766af8e2e930e653be7e4b75fa0c8bdb187cb1bec293f265d9159ff, the -harbor suffix is appended if the chart release name does not contain harbor as a substring. In the latest diff, i've changed the above to now respect that behaviour
| @@ -19,7 +19,7 @@ func CreateInstance(name, namespace string) *v1alpha2.Instance { | |||
| Type: "manual", | |||
| InstanceURL: "https://core.harbor.domain", | |||
| GarbageCollection: &v1alpha2.GarbageCollection{ | |||
| Cron: "0 * * * *", | |||
| Cron: "0 * * * * *", | |||
There was a problem hiding this comment.
What's up with the new cronjob pattern? Is the sixth segment required, now? How do we handle compatibility in this case?
There was a problem hiding this comment.
With https://github.com/goharbor/harbor/blob/320c64e4335685952a76c22bcd76e88c611918d8/src/common/utils/utils.go#L299 a custom cron parser was introduced that now requires us to also use the Second parameter (Note that the parser is using Second and not SecondOptional, as suggested in the guide on how to retain the old behaviour). In the latest diff, the cron schedule used to configure Harbor garbage collection will contain a prepended * if left unspecified in helm values.
|
superseded by: #115 /close |
No description provided.