An attempt to add paging support in a generic way. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some testing on this branch and it works for calls I make that need more pages and no known impact to calls for single pages. |
|
Thanks for validating. By the way, I did not want to overrule your PR, as you also took the time to come up with an implementation. So I hope you are okay with this approach as well? |
|
100% ok with this approach. It is nice and clean. I am enjoying the learning and engagement. Thanks for checking. |
|
I have been testing costByResource, which didn't support paging before, and it is looking fine until now. Have exported > 38k lines on one occasion. |
|
Thanks for validating this change guys! I will merge it and prepare a package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.