In Demo project applied xcode recommended settings, fixed warnings.

mixdesign · Mar 17, 2016 · c9e0551 · c9e0551
1 parent a8b178d
commit c9e0551
Show file tree

Hide file tree

Showing 4 changed files with 94 additions and 483 deletions.
diff --git a/Demo/AAShareBubbles.xcodeproj/project.pbxproj b/Demo/AAShareBubbles.xcodeproj/project.pbxproj
@@ -165,7 +165,7 @@
 		CEBAD0961844B41100D66BBB /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 0460;
+				LastUpgradeCheck = 0720;
 				ORGANIZATIONNAME = "GoodApp inc.";
 			};
 			buildConfigurationList = CEBAD0991844B41100D66BBB /* Build configuration list for PBXProject "AAShareBubbles" */;
@@ -262,6 +262,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
 				COPY_PHASE_STRIP = NO;
+				ENABLE_TESTABILITY = YES;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
 				GCC_DYNAMIC_NO_PIC = NO;
 				GCC_OPTIMIZATION_LEVEL = 0;
@@ -313,6 +314,7 @@
 				GCC_PREFIX_HEADER = "AAShareBubbles/AAShareBubbles-Prefix.pch";
 				INFOPLIST_FILE = "AAShareBubbles/AAShareBubbles-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 5.0;
+				PRODUCT_BUNDLE_IDENTIFIER = "com.goodapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = app;
 			};
@@ -325,6 +327,7 @@
 				GCC_PREFIX_HEADER = "AAShareBubbles/AAShareBubbles-Prefix.pch";
 				INFOPLIST_FILE = "AAShareBubbles/AAShareBubbles-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 5.0;
+				PRODUCT_BUNDLE_IDENTIFIER = "com.goodapp.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = app;
 			};

diff --git a/Demo/AAShareBubbles/AAShareBubbles-Info.plist b/Demo/AAShareBubbles/AAShareBubbles-Info.plist
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.goodapp.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

diff --git a/Demo/AAShareBubbles/ViewController.m b/Demo/AAShareBubbles/ViewController.m
@@ -72,7 +72,7 @@ - (IBAction)bubbleRadiusValueChanged:(id)sender {
 #pragma mark -
 #pragma mark AAShareBubbles
 
--(void)aaShareBubbles:(AAShareBubbles *)shareBubbles tappedBubbleWithType:(int)bubbleType
+-(void)aaShareBubbles:(AAShareBubbles *)shareBubbles tappedBubbleWithType:(AAShareBubbleType)bubbleType
 {
     switch (bubbleType) {
         case AAShareBubbleTypeFacebook:
@@ -103,7 +103,7 @@ -(void)aaShareBubbles:(AAShareBubbles *)shareBubbles tappedBubbleWithType:(int)b
             NSLog(@"Reddit");
             break;
         case CUSTOM_BUTTON_ID:
-            NSLog(@"Custom Button With Type %d", bubbleType);
+            NSLog(@"Custom Button With Type %@", @(bubbleType));
             break;
         default:
             break;