Skip dumping the buffer in STARMAN_DEBUG=1 #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starman debug mode prints the request header and body to the console, and enabling it on production could cause an incident where unwanted private information is logged. meanwhile, the other information displayed with the debug option could be still useful to monitor on a production environment.
This PR adds a new value of
STARMAN_DEBUG=2
to enable request buffer logging, whileSTARMAN_DEBUG=1
will skip printing the request buffer. This is a breaking change if someone relies on the debug option printing the full request buffer to STDERR, but i would consider it's a reasonable change since it is explicitly named "debug" and we'll make sure to document it in Changes.