-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images, use unicode, rework paragraphs and runs #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later on this will be abstracted away into a render style structure or similar, but for now let's expose them directly
If no run is present in the current paragraph, create a new empty run and insert it in the appropriate place.
Use a placeholder character for opaque fragments and regular textual content for runs.
This is a mammoth commit which fully refactors the engine to use UTF-8 unicode encoding for all text operations. As far as I can tell, everything works on par with before. The tests still need to be ported over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive refactoring to allow us to support images. This touches just about every part of the engine, from implementing Unicode string handling to reworking how we treat paragraphs and their children.
Handle sizingPostpone actual bitmap rendering to future PRPart of #30
In subsequent PRs: