Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add vite base #35

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Feat/add vite base #35

merged 4 commits into from
Dec 5, 2024

Conversation

Dsaquel
Copy link
Contributor

@Dsaquel Dsaquel commented Dec 4, 2024

fixes #34

@Dsaquel Dsaquel force-pushed the feat/add-vite-base branch from 78019d3 to 1b0e443 Compare December 4, 2024 20:05
Copy link
Owner

@mjhoy mjhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! I just had one note. Can you also add a note to the changelog under the unreleased section?

src/vite.rs Outdated Show resolved Hide resolved
src/vite.rs Show resolved Hide resolved
@Dsaquel Dsaquel force-pushed the feat/add-vite-base branch from ddded82 to 159f816 Compare December 5, 2024 20:36
@Dsaquel Dsaquel requested a review from mjhoy December 5, 2024 20:57
Copy link
Owner

@mjhoy mjhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, lgtm

@mjhoy mjhoy merged commit fcd9c89 into mjhoy:main Dec 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Add "base public path" configuration
2 participants