Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning: catching polymorphic type 'class std::runtime_error' by value [-Wcatch-value=] #73

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Fix warning: catching polymorphic type 'class std::runtime_error' by value [-Wcatch-value=] #73

merged 1 commit into from
Feb 24, 2024

Conversation

Thomasb81
Copy link
Contributor 

|| topology_graph.cpp: In member function 'bool topology::EdgePoint::assertConvexBend() const':
libtopology/./topology_graph.cpp|298 col 31| warning: catching polymorphic type 'class std::runtime_error' by value [-Wcatch-value=]
||   298 |         } catch(runtime_error e) {
||       |                               ^

@Thomasb81
libtopology/./topology_graph.cpp|298 col 31| warning: catching polymo…
e82d2db 
…rphic type 'class std::runtime_error' by value [-Wcatch-value=]

||   298 |         } catch(runtime_error e) {
||       |                               ^
@skieffer skieffer merged commit 9214707 into mjwybrow:master Feb 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomasb81 @skieffer