Use src/distrooptions.h as another source #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier for distributions to patch the source directory, rather than needing to create localoptions.h in the build directory. Makefile's OPTION_HEADERS is removed, the wildcard *.h covers it
geissonator
pushed a commit
to openbmc/openbmc
that referenced
this pull request
Feb 20, 2024
Per the dropbear documentation, the localoptions.h file needs to be copied to its build directory to take effect. This file can later be renamed to src/distrooptions.h once the following dropbear change is merged: mkj/dropbear#274 Tested: Before change: $ ssh -vv p10bmc ... debug2: MACs ctos: hmac-sha1,hmac-sha2-256 debug2: MACs stoc: hmac-sha1,hmac-sha2-256 After change: $ ssh -vv p10bmc ... debug2: MACs ctos: hmac-sha1,hmac-sha2-256,hmac-sha2-512 debug2: MACs stoc: hmac-sha1,hmac-sha2-256,hmac-sha2-512 Change-Id: I1a4b108d1a87831f4623c7e3e1e2beb0b8655441 Signed-off-by: Adriana Kobylak <[email protected]>
rfrandse
pushed a commit
to ibm-openbmc/openbmc
that referenced
this pull request
Mar 28, 2024
Per the dropbear documentation, the localoptions.h file needs to be copied to its build directory to take effect. This file can later be renamed to src/distrooptions.h once the following dropbear change is merged: mkj/dropbear#274 Tested: Before change: $ ssh -vv p10bmc ... debug2: MACs ctos: hmac-sha1,hmac-sha2-256 debug2: MACs stoc: hmac-sha1,hmac-sha2-256 After change: $ ssh -vv p10bmc ... debug2: MACs ctos: hmac-sha1,hmac-sha2-256,hmac-sha2-512 debug2: MACs stoc: hmac-sha1,hmac-sha2-256,hmac-sha2-512 Change-Id: I1a4b108d1a87831f4623c7e3e1e2beb0b8655441 Signed-off-by: Adriana Kobylak <[email protected]>
rfrandse
pushed a commit
to ibm-openbmc/openbmc
that referenced
this pull request
Apr 19, 2024
Per the dropbear documentation, the localoptions.h file needs to be copied to its build directory to take effect. This file can later be renamed to src/distrooptions.h once the following dropbear change is merged: mkj/dropbear#274 Tested: Before change: $ ssh -vv p10bmc ... debug2: MACs ctos: hmac-sha1,hmac-sha2-256 debug2: MACs stoc: hmac-sha1,hmac-sha2-256 After change: $ ssh -vv p10bmc ... debug2: MACs ctos: hmac-sha1,hmac-sha2-256,hmac-sha2-512 debug2: MACs stoc: hmac-sha1,hmac-sha2-256,hmac-sha2-512 Change-Id: I1a4b108d1a87831f4623c7e3e1e2beb0b8655441 Signed-off-by: Adriana Kobylak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for distributions to patch the source directory, rather than needing to create localoptions.h in the build directory.
Makefile's OPTION_HEADERS is removed, the wildcard *.h covers it