Re-add host to "Login attempt for nonexistent user" log #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkj#83 removed the host from the final message part of early exit messages, and added it to the initial message part instead. This was however done for "Login attempt for nonexistent user" as well, which is no early exit message, but allows the client to keep trying. Those log entries hence now do not contain a host anymore. This PR reverts this part of mkj#83 to restore the missing host, and re-enable software like Fail2Ban to track these login failures. Signed-off-by: MichaIng <[email protected]>
This was referenced Jul 10, 2024
|
Thanks, sorry for the delay with this |
|
@mkj thanks for merging. For completeness, the same should be done for "Login attempt with wrong user" as well, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83 removed the host from the final message part of early exit messages, and added it to the initial message part instead. This was however done for "Login attempt for nonexistent user" as well, which is no early exit message, but allows the client to keep trying. Those log entries hence now do not contain a host anymore.
This PR reverts this part of #83 to restore the missing host, and re-enable software like Fail2Ban to track these login failures.
As mentioned in #83, I guess "Login attempt with wrong user" (when Dropbear runs as non-root user) is no early exit message as well, and hence needs to be reverted the same way. Probably someone can verify this quicker than me.