remove symlinks #191
Merged
remove symlinks #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
commented
Feb 10, 2025
| @@ -31,8 +31,14 @@ let package = Package( | |||
| .target( | |||
| name: "Cmlx", | |||
| exclude: [ | |||
| // exclude here -- it is part of the include directory (public api) | |||
| "mlx-c", | |||
There was a problem hiding this comment.
Previously this was picked up via the symlink in include, but now we will build it directly.
davidkoski
commented
Feb 10, 2025
| // example code + mlx-c distributed | ||
| "mlx-c/examples", | ||
| "mlx-c/mlx/c/distributed.cpp", | ||
| "mlx-c/mlx/c/distributed_group.cpp", |
There was a problem hiding this comment.
Don't build these
davidkoski
commented
Feb 10, 2025
| @@ -10,6 +10,10 @@ then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # copy mlx-c headers to build area | |||
| rm -f Source/Cmlx/include/mlx/c/* | |||
| cp Source/Cmlx/mlx-c/mlx/c/*.h Source/Cmlx/include/mlx/c | |||
There was a problem hiding this comment.
We don't have a symlink in include any more -- just copy these headers in so we get the proper directory structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes symlinks from checkout -- just move the directories where they need to be.
This looks massive but it is mostly renames. The interesting pieces: