Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylegan implementation #19

Merged
merged 14 commits into from
Nov 7, 2024
Merged

Stylegan implementation #19

merged 14 commits into from
Nov 7, 2024

Conversation

szmazurek
Copy link
Contributor

Fixes #

Proposed Changes

  • added stylegan implementation
  • full support for both 2D and 3D training

Checklist

  • Tests have been run (pytest --cov=. --cov-report=xml) and the result (coverage report -m) has been pasted here for reviewers.
  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF-Synth main branch.
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml.

@szmazurek szmazurek requested a review from a team as a code owner November 2, 2024 23:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@szmazurek
Cleaning up:
afa2650 
- refactoring dcgan module and removing unused methods
- removing redundant todo from datasets file
@szmazurek
Wrapping up stylegan
9de46bc
@szmazurek szmazurek changed the title Stylegan Stylegan implementation Nov 3, 2024
sarthakpati
sarthakpati reviewed Nov 6, 2024
View reviewed changes
gandlf_synth/models/modules/stylegan_module.py
with the new one if it exists. If it doesn't, it adds the new resize transform to the
existing transforms at the end.
"""
current_resize_transform = self._determine_current_resize_transform()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have the warning here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it in the module initialization

@szmazurek szmazurek merged commit ded5f85 into mlcommons:main Nov 7, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szmazurek @sarthakpati