-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preparing sync between branches to avoid divergence #330
Changes from all commits
ec5d0df
c1eb857
db60dad
28b817e
c97f1fe
df4013c
9a7057e
6b02a9d
5c74925
8dbc038
653270c
2087704
773ef26
de55cc1
a8feebd
c5aeb3d
9b79c55
07ef382
2924ce6
e3b43b8
62c38ef
f8a4e7a
afaee88
07da361
47b2fd7
79871c0
1051735
2593657
5419871
44251aa
0942459
d459ef6
7dcaa61
a92f8d5
09a09a1
e71477a
b522d7e
b0a217e
c4f69f6
1927b5d
149a474
b9cfe35
535d0d5
c39c0f9
9be5704
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
Copyright (c) 2021-2024 MLCommons | ||
|
||
The cTuning foundation and OctoML donated this project to MLCommons to benefit everyone. | ||
Grigori Fursin, the cTuning foundation and OctoML donated this project to MLCommons to benefit everyone. | ||
|
||
Copyright (c) 2014-2021 cTuning foundation |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -139,6 +139,11 @@ cm run script \ | |
|
||
[Apache 2.0](LICENSE.md) | ||
|
||
## CM concepts | ||
|
||
* https://doi.org/10.5281/zenodo.8105339 | ||
* https://arxiv.org/abs/2406.16791 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should remove this arxiv paper - it has many factually wrong things. You had earlier agreed to fix them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here is the PR: #336 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you Grigori. Yes, not just the typos - "Arjun Suresh - a senior software engineer from cKnowledge.org" - I was at OctoML and only later at cKnowledge and even there the title was not the same. And I think in the last section "Future Plans" you made a typo to use "We" as everywhere else in the PDF it is "I". |
||
|
||
## Authors | ||
|
||
[Grigori Fursin](https://cKnowledge.org/gfursin) and [Arjun Suresh](https://www.linkedin.com/in/arjunsuresh) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
alias: benchmark-run-mlperf-inference-v4.1 | ||
uid: b7e89771987d4168 | ||
|
||
automation_alias: cfg | ||
automation_uid: 88dce9c160324c5d | ||
|
||
tags: | ||
- benchmark | ||
- run | ||
- mlperf | ||
- inference | ||
- v4.1 | ||
|
||
name: "MLPerf inference - v4.1" | ||
|
||
supported_compute: | ||
- ee8c568e0ac44f2b | ||
- fe379ecd1e054a00 | ||
- d8f06040f7294319 | ||
|
||
bench_uid: 39877bb63fb54725 | ||
|
||
view_dimensions: | ||
- - input.device | ||
- "MLPerf device" | ||
- - input.implementation | ||
- "MLPerf implementation" | ||
- - input.backend | ||
- "MLPerf backend" | ||
- - input.model | ||
- "MLPerf model" | ||
- - input.scenario | ||
- "MLPerf scenario" | ||
- - input.host_os | ||
- "Host OS" | ||
- - output.state.cm-mlperf-inference-results-last.performance | ||
- "Got performance" | ||
- - output.state.cm-mlperf-inference-results-last.accuracy | ||
- "Got accuracy" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
uid: 12e86eb386314866 | ||
|
||
name: "Basic Ubuntu 24.04" | ||
|
||
input: | ||
docker_base_image: 'ubuntu:24.04' | ||
docker_os: ubuntu | ||
docker_os_version: '24.04' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should agree on the history and keep it stable - it doesn't look good if it keeps on changing. Technically cm4mlops and all the code inside it started within MLCommons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parts of the code comes from older versions of CK and CM and from the https://github.com/mlcommons/ck where it was originally resided. We have to reflect that to avoid legal problems in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally started developing CM4MLOps as an integral part of CM while reusing some parts of CK and CK4MLOps that I developed at cTuning so it has to have a common history and license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://octo.ai/blog/octoml-joins-the-community-effort-to-democratize-mlperf-inference-benchmarking - CM and CM4MLOps was a part of CK project at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OctoAI blog has nothing to do with CM as it is talking about results taken using CK. Anyway I do not want to argue over these things. Since none of the projects are new, I request you to finalize the historical attributions and contributions and and keep them constant. This can help others decide in using the project. If anyone has a concern that the history of a project can change in future no one will be happy to contribute to it. Or else, let git history take care of them automatically as done in most other MLCommons repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Agree! Thank you!
But we still have a problem with the conflict in .github/workflows/test-mlperf-inference-resnet50.yml .
May I ask you to help resolve it and merge the PR, please?
Thanks a lot for your help - very appreciated!