Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic quality checks in GitHub Actions for the editor. #321

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Add automatic quality checks in GitHub Actions for the editor. #321

merged 6 commits into from
Nov 10, 2023

Conversation

marcenacp
Copy link
Contributor

@marcenacp marcenacp commented Nov 8, 2023 •
edited
Loading 

pip install --upgrade black isort
make format

@marcenacp marcenacp requested a review from a team as a code owner November 8, 2023 16:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@marcenacp marcenacp force-pushed the feature/add-quality-to-github-for-editor branch 2 times, most recently from 045e044 to f0197df Compare November 8, 2023 16:49
@marcenacp marcenacp changed the title [WIP] Add quality automatic quality checks in GitHub Actions for the editor. Add quality automatic quality checks in GitHub Actions for the editor. Nov 8, 2023
ccl-core
ccl-core reviewed Nov 8, 2023
View reviewed changes
python/mlcroissant/mlcroissant/_src/core/git.py
raise RuntimeError(
"Problem when launching `git lfs`. "
"Possible problems: Have you installed git lfs "
f"locally? Is '{fullpath}' a valid `git lfs` "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more readable if it would display Possible problems:\n\t* Have you installed ...?\n\t* Is '{fullpath}' ...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only aims at reformating the code using the last version of black

ccl-core
ccl-core approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ccl-core ccl-core left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcenacp marcenacp changed the title Add quality automatic quality checks in GitHub Actions for the editor. Add automatic quality checks in GitHub Actions for the editor. Nov 10, 2023
@marcenacp marcenacp force-pushed the feature/add-quality-to-github-for-editor branch from f0197df to 26bee88 Compare November 10, 2023 13:24
@marcenacp marcenacp merged commit 54df95d into main Nov 10, 2023
13 checks passed
@marcenacp marcenacp deleted the feature/add-quality-to-github-for-editor branch November 10, 2023 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ccl-core ccl-core ccl-core approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcenacp @ccl-core